feat: add an inline OM created timestamp syntax#760
feat: add an inline OM created timestamp syntax#760Maniktherana wants to merge 1 commit intoprometheus:mainfrom
Conversation
Signed-off-by: Manik Rana <manikrana54@gmail.com>
ArthurSens
left a comment
There was a problem hiding this comment.
Nice, thanks for starting this!
I think we may want a different approach though, OpenMetrics 1.0 is not going away, so we need to keep the _created lines for users of that version of the protocol.
What we want is a separate implementation for 2.0.
understood, how can we manage both implementations together? Do we use a feature flag for this? |
|
Feedback from our call: Clients who use prometheus/common to encode data use We can try two options and see what works best:
|
this PR aims to update the created timestamp syntax as outlined in the following proposal: prometheus/proposals#43