Expose HTTPHost property in HTTPClientConfig#645
Expose HTTPHost property in HTTPClientConfig#645jkroepke wants to merge 3 commits intoprometheus:mainfrom
Conversation
c414f4d to
e849aa2
Compare
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
bboreham
left a comment
There was a problem hiding this comment.
Turns out that I forget something.
Please explain this further.
|
In #549 you added Since only the latter was used, I removed the former. Now you adding it back, and hopefully using it. |
|
Hey @bboreham, I only need the property in HTTPClientConfig within the context of Grafana Alloy. I have to apologize. When I started with Golang a year ago, I implemented the wrong side due to my lack of knowledge and missing tooling. I just replicated the userAgent logic, which misled me. Looking at it now, I realize that the host property in httpClientOptions is incorrect. If you agree, I can revert the host in httpClientOptions. |
|
Thanks for the explanation. It's fine, everybody makes mistakes. Just easier for me to follow if I can see the path. However we may prefer to deprecate the un-needed one rather than removing it immediately. |
|
Hi! Anything missing here? |
Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de>
|
@SuperQ from my understanding, the review asks for a more specific doc note which I applied now. |
While I was integrate that feature in grafana/alloy#698, it figure out that the Host property was removed in #597. Turns out that I forget something.
Since host is problematic with DockerSD, i choice the term
http_hostto follow the pattern fromhttp_headers