feature: add ResponseFormatIncludingMetrics helper func#503
Open
bartsmykla wants to merge 2 commits intoprometheus:mainfrom
Open
feature: add ResponseFormatIncludingMetrics helper func#503bartsmykla wants to merge 2 commits intoprometheus:mainfrom
bartsmykla wants to merge 2 commits intoprometheus:mainfrom
Conversation
As there is existing similar function for encoder `NegotiateIncludingOpenMetrics`, introducing function for parsing format from `content-type` header will be useful. Signed-off-by: Bart Smykla <bartek@smykla.com>
Author
|
@roidelapluie I would love to get your review/opinion about this :-) |
Signed-off-by: Bart Smykla <bartek@smykla.com>
6 tasks
Author
|
@discordianfish @roidelapluie what is your opinion about this change? :-) |
Author
|
@roidelapluie would you have a minute to look at this? :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As there is existing similar function for encoder
NegotiateIncludingOpenMetrics, introducing function for parsing format fromcontent-typeheader will be useful.I'm opening this PR as a result of me reviewing contribution to kuma: kumahq/kuma#7125
Instead of writing own implementation for the same functionality having this upstream, may be useful for others as well.