(opt) Add HealthCheckError and Configurable Retry Logic#1620
Merged
gianlucam76 merged 1 commit intoprojectsveltos:mainfrom Feb 18, 2026
Merged
(opt) Add HealthCheckError and Configurable Retry Logic#1620gianlucam76 merged 1 commit intoprojectsveltos:mainfrom
gianlucam76 merged 1 commit intoprojectsveltos:mainfrom
Conversation
4bd0368 to
c5cce64
Compare
c5cce64 to
ee61ef2
Compare
This PR introduces a specialized HealthCheckError type to differentiate between clusterSUmmary deployment failures and functional health check failures. It also adds a configurable flag to control the retry interval when these health checks fail. Introduced a new CLI flag `--health-error-retry-time` (default: 90 seconds). This allows the controller to back off specifically on health check failures without impacting the standard reconciliation requeue logic for other errors. When a health check fails, the reconciler now uses the dedicated healthErrorRetryTime duration.
ee61ef2 to
248f283
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a specialized HealthCheckError type to
differentiate between clusterSUmmary deployment failures
and functional health check failures. It also adds a configurable
flag to control the retry interval when these health checks fail.
Introduced a new CLI flag
--health-error-retry-time(default:90 seconds). This allows the controller to back off specifically
on health check failures without impacting the standard reconciliation
requeue logic for other errors.
When a health check fails, the reconciler now uses the dedicated
healthErrorRetryTime duration.