Nativo: Add optional placementId parameter#4380
Open
rafataveira wants to merge 1 commit intoprebid:masterfrom
Open
Nativo: Add optional placementId parameter#4380rafataveira wants to merge 1 commit intoprebid:masterfrom
rafataveira wants to merge 1 commit intoprebid:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds integration test coverage for the Nativo bidder adapter. It introduces a JSON schema for validating Nativo adapter parameters, a new integration test class, and the corresponding test request and response fixtures.
Integration test for Nativo adapter:
NativoTestto verify that the OpenRTB auction endpoint responds correctly with bids from the Nativo bidder. The test uses WireMock to stub the Nativo exchange and validates the auction response.Test fixtures for Nativo integration:
test-auction-nativo-request.json,test-auction-nativo-response.json) and for the Nativo bid exchange (test-nativo-bid-request.json,test-nativo-bid-response.json). [1] [2] [3] [4]Schema validation:
nativo.jsonto define and validate the parameters accepted by the Nativo adapter.🔧 Type of changes
✨ What's the context?
Adding optional property "placementId" to Nativo Adapter.
🧠 Rationale behind the change
We have already been using this property but it wasn't correctly documented into the adapter.
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
Yes, just adding new optional property
🏎 Quality check