Mobkoi: Always set the TagID with our placementID#4327
Open
gabrielmougard wants to merge 1 commit intoprebid:masterfrom
Open
Mobkoi: Always set the TagID with our placementID#4327gabrielmougard wants to merge 1 commit intoprebid:masterfrom
gabrielmougard wants to merge 1 commit intoprebid:masterfrom
Conversation
CTMBNara
requested changes
Jan 5, 2026
src/test/java/org/prebid/server/bidder/mobkoi/MobkoiBidderTest.java
Outdated
Show resolved
Hide resolved
| assertThat(result.getValue()) | ||
| .extracting(httpRequest -> mapper.readValue(httpRequest.getBody(), BidRequest.class)) | ||
| .flatExtracting(BidRequest::getImp) | ||
| .extracting(imp -> imp.getTagid()) |
Collaborator
There was a problem hiding this comment.
@gabrielmougard please address the previous comment here as well as in other similar instances to ensure consistency across PR
Collaborator
|
@gabrielmougard any update? |
Author
|
Hi @osulzhenko , will update today, thanks for the reminder :) |
We have a discrepancy between our Prebid Server and our Tag/PrebidJS integration. It’s not replacing the `bidrequest.Imp[0].TagID` with our internal value when a TagID is already present. We are able to deliver because the value is set in the `bidrequest.Imp[0].Ext.placementID` field, but this creates discrepancies between the connectors, and it’s not ideal.
gabrielmougard
force-pushed
the
mobkoi-MAX-1892
branch
from
79604dd to
31d3a39
Compare
Collaborator
|
@gabrielmougard also: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
We have a discrepancy between our Prebid Server and our Tag/PrebidJS integration. It’s not replacing the
bidrequest.Imp[0].TagIDwith our internal value when a TagID is already present. We are able to deliver because the value is set in thebidrequest.Imp[0].Ext.placementIDfield, but this creates discrepancies between the connectors, and it’s not ideal.