Rails 3 support#3
Open
expandrive wants to merge 29 commits intopotionfactory:masterfrom
expandrive:master
Open
Rails 3 support#3expandrive wants to merge 29 commits intopotionfactory:masterfrom expandrive:master
expandrive wants to merge 29 commits intopotionfactory:masterfrom
expandrive:master
Conversation
Conflicts: app/views/admin/index.html.erb
Collaborator
|
I'll try to find some free time to merge all this into the main branch. I also have to merge my development changes so this will take some effort. |
Collaborator
|
@remear Ben, I'm looking forward to seeing your changes as well. |
|
This pull request is superseded by #4, which contains many improvements since this pull request was sent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails 3 has been out for 18 months now and it's time to bring potion store up to date, for security fixes and future-proofing, if nothing else. With Rails 4 due sometime this year, I think it's time to roll up our sleeves and move forward.
I've merged the changes made by Ben Mills and Evan Sparkman atop the current master branch and have done a fair amount of testing over here. Works well, installation is simple.