This repository was archived by the owner on May 21, 2019. It is now read-only.
Open
Conversation
Adding multi-threaded libpmemalloc test. At the time of this commit, libpmemalloc is not mt-safe. Adding the test first as a first step.
Author
|
Added updates to pmemalloc.h and .c to augment the comments on_allocate and on_free. The inputs description now matches the actual parameters. I also removed the trailing '_' from the parentp pointer since it is actually an absolute (regular) pointer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
30 November:
Added pthread mutex protection to pmemalloc library. Mutexes are currently stored in the persistent pool header. A subsequent optimization should be to move those into a volatile pool state structure but this implementation works as an example.
Take quick look when you get a chance and let me know any comments. This is a pthread-based pmemalloc test as a first step towards making the library mt-safe.
/Ken