Skip to content

Test PHP 8.5 too #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mlocati merged 2 commits into from
Feb 23, 2026
Merged

Test PHP 8.5 too #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86f9ec2
Test PHP 8.5 too
mlocati Feb 23, 2026
ab67ce0
Use http_get_last_response_headers() instead of $http_response_header…
mlocati Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: "8.1"
php-version: "8.5"
extensions: mbstring, zip
tools: composer:2, php-cs-fixer:3
coverage: none
Expand All @@ -43,7 +43,7 @@ jobs:
matrix:
php-version:
- "5.3"
- "8.4"
- "8.5"
steps:
-
name: Setup PHP
Expand Down Expand Up @@ -91,13 +91,14 @@ jobs:
- "8.2"
- "8.3"
- "8.4"
- "8.5"
include:
- os: windows-latest
php-version: "5.6"
- os: windows-latest
php-version: "7.4"
- os: windows-latest
php-version: "8.4"
php-version: "8.5"
runs-on: ${{ matrix.os }}
steps:
-
Expand Down
16 changes: 13 additions & 3 deletions bin/import-cldr-data
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,14 +173,24 @@ class DocumentStorage
private function fetch($path)
{
$url = $this->baseUrl . '/' . ltrim($path, '/');
if (defined('PHP_VERSION_ID') && \PHP_VERSION_ID >= 80400) {
http_clear_last_response_headers();
}
set_error_handler(function () {}, -1);
$content = file_get_contents($url, false, $this->context);
restore_error_handler();
if ($content === false) {
$details = '';
/** @var array $http_response_header */
if (!empty($http_response_header)) {
$details = " - {$http_response_header[0]}";
if (defined('PHP_VERSION_ID') && \PHP_VERSION_ID >= 80400) {
$lastResponseHeaders = http_get_last_response_headers();
} elseif (!empty($http_response_header)) {
$varName = 'http_response_header';
$lastResponseHeaders = ${$varName};
} else {
$lastResponseHeaders = null;
}
if (!empty($lastResponseHeaders)) {
$details = " - {$lastResponseHeaders[0]}";
}
throw new RuntimeException("Failed to download from {$url}{$details}");
}
Expand Down