Skip to content

ci: move to node 24 lts #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abose merged 2 commits into from
Jan 28, 2026
Merged

ci: move to node 24 lts #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d3e942
ci: move to node 24 lts
abose Jan 28, 2026
fec3bb8
fix: node 24 incompatible with tauri unc paths causing test framework…
abose Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test-on-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: setup node
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 24
- name: install Rust stable
uses: dtolnay/rust-toolchain@stable
with:
Expand Down Expand Up @@ -71,7 +71,7 @@ jobs:
- name: setup node
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 24
- name: install dependencies
run: |
sudo apt-get update
Expand Down
5 changes: 5 additions & 0 deletions test/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@
let commandId = 0, pendingCommands = {};
if(window.__TAURI__){
window.__TAURI__.path.resolveResource("node-src/index.js").then(async nodeSrcPath=>{
// Strip Windows UNC prefix (\\?\) that Tauri adds on Windows
// Node 24 doesn't handle UNC paths correctly in module resolution
if (window.IS_WINDOWS && nodeSrcPath.startsWith('\\\\?\\')) {
nodeSrcPath = nodeSrcPath.slice(4);
}
command = new window.__TAURI__.shell.Command('node', ['--inspect', nodeSrcPath]);
command.on('close', data => {
window.isNodeTerminated = true;
Expand Down
Loading