This repository was archived by the owner on Jun 19, 2023. It is now read-only.
Bugfix/help text and reorder rename args#403
Open
bmcdonnell wants to merge 3 commits intopetervanderdoes:developfrom
Open
Bugfix/help text and reorder rename args#403bmcdonnell wants to merge 3 commits intopetervanderdoes:developfrom
bmcdonnell wants to merge 3 commits intopetervanderdoes:developfrom
Conversation
…<old_name>] <new_name>`, following git conventions (like `git branch --move [<oldbranch>] <newbranch>`)
|
I'm in the process of updating gitflow. If you could kindly resubmit your pull request against my fork here as it appears this fork is no longer being updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c0b4b96 and d6e43fd add/revise some help text. I think it's a given that you'll want to pull those in, except maybe if you want to change the printout order or something.
cf3885e may be debatable. It flips the order of the
renamesub-subcommand arguments to match git conventions--most compellingly,git branch --move [<oldbranch>] <newbranch>(where oldbranch is optional and first). In other cases, "old" isn't optional, but it's still first:git mv <source> <destination>git diff <oldcommit> [<newcommit>]git remote rename <old> <new>Since
renamewas just introduced in 1.11.0, less than a year ago, it wasn't fully documented, and error messages should point users in the right direction, would you consider this change is a reasonably small disruption?