Skip to content

Add data directory to gitignore#1295

Merged
DanGould merged 1 commit intopayjoin:masterfrom
zealsham:update-gitignore
Jan 23, 2026
Merged

Add data directory to gitignore#1295
DanGould merged 1 commit intopayjoin:masterfrom
zealsham:update-gitignore

Conversation

@zealsham
Copy link
Collaborator

@zealsham zealsham commented Jan 23, 2026

When you run the new payjoin-service, it creates a data directory which isn't part of the gitignore files and thus getting tracked by git.

Pull Request Checklist

Please confirm the following before requesting review:

When you run the new payjoin-service, it creates a data directory
which isn't part of the gitignore files and thus getting tracked
by git.
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 21283264520

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.203%

Totals Coverage Status
Change from base Build 21267453749: 0.0%
Covered Lines: 10140
Relevant Lines: 12187

💛 - Coveralls

@DanGould
Copy link
Contributor

this makes me question whether the data in the data directory is in the home it ought to be in

@zealsham
Copy link
Collaborator Author

this makes me question whether the data in the data directory is in the home it ought to be in

the current behaviour creates the data directory in whatever working directory the binary is called from. We should have a dedicated directory just as we have for the cli

@DanGould DanGould merged commit 0638a45 into payjoin:master Jan 23, 2026
13 checks passed
@spacebear21
Copy link
Collaborator

The directory is configurable in config.toml and defaults to ./data. Arguably we could not set a default and require it to be explicit, as Yuval suggested here #1095 (comment)

FWIW I had added *.dat to the .gitignore in payjoin-service, I suppose that's not effective if the binary is run from the top-level directory, perhaps we should move that to this top-level .gitignore (I'd also prefer using specific known files instead of a common dir name like data in .gitignore).

@DanGould
Copy link
Contributor

specific file > common directory name. Agree cACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments