Add data directory to gitignore#1295
Conversation
When you run the new payjoin-service, it creates a data directory which isn't part of the gitignore files and thus getting tracked by git.
Pull Request Test Coverage Report for Build 21283264520Details
💛 - Coveralls |
|
this makes me question whether the data in the data directory is in the home it ought to be in |
the current behaviour creates the data directory in whatever working directory the binary is called from. We should have a dedicated directory just as we have for the cli |
|
The directory is configurable in config.toml and defaults to FWIW I had added *.dat to the .gitignore in payjoin-service, I suppose that's not effective if the binary is run from the top-level directory, perhaps we should move that to this top-level .gitignore (I'd also prefer using specific known files instead of a common dir name like |
|
specific file > common directory name. Agree cACK |
When you run the new payjoin-service, it creates a data directory which isn't part of the gitignore files and thus getting tracked by git.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.