Validate FFI primitive inputs + refresh bindings/tests by chavic · Pull Request #1263 · payjoin/rust-payjoin

chavic · 2026-01-10T07:03:15Z

This PR addresses #1262 and hardens the FFI boundary by validating primitive inputs and surfacing explicit errors. Updates integration tests/bindings to match the new error shapes and removes silent acceptance of invalid fee rates/amounts.

Follow-ups

Decide final script/witness size caps and document rationale.
Add Dart integration fix for large fee rate parsing (separate PR).

coveralls · 2026-01-10T07:09:52Z

Pull Request Test Coverage Report for Build 22112284749

Details

3 of 5 (60.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 83.169%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
payjoin/src/core/psbt/mod.rs	0	2	0.0%

Totals
Change from base Build 22022393890:	-0.01%
Covered Lines:	10219
Relevant Lines:	12287

💛 - Coveralls

benalleng

Instead of updating the msrv for dart I think we can simply use cargo install --locked wasm-bindgen-cli on the js workflow to prevent the install step from trying to update the deps

chavic · 2026-02-04T14:27:16Z

Instead of updating the msrv for dart I think we can simply use cargo install --locked wasm-bindgen-cli on the js workflow to prevent the install step from trying to update the

Thanks... applying that now

benalleng

CACK f331ef3 got the commits nicely reviewable again thanks for that.

benalleng

I think you may have misunderstood my comments on the review, the psbt consts can be simply imported and not set as strings in the tests. I appreciate seeing the test_utils.dart but it was not really my intention to need to add this.

benalleng · 2026-02-11T17:32:16Z

payjoin-ffi/javascript/test/integration.test.ts

you've kind of reversed what you did here that you did in the dart file

This fell back during the rebase; I had a backup branch, so I'll bring it back. Side note, I've noticed only the Python test fails if the poll approach isn't used... will try to find out why (not the top task)

sidenote, should we consider asserting a failure when attempts exceed 3, unless the intent is explicitly “smoke test only”

benalleng · 2026-02-11T17:36:48Z

payjoin-ffi/dart/test/test_payjoin_integration_test.dart

The can actually just be

final psbt = test_utils.originalPsbt();

you will need to add it to the test_utils.dart import though

Related note (but not a blocker for this PR), we should really not expose test utils in the main payjoin namespace for language bindings. This test_utils approach is a nice helper but the test utils are still exposed in the main namespace. I tried my hand at this briefly and couldn't find a good approach #1199 (comment)

payjoin-ffi/python/test/test_payjoin_unit_test.py

payjoin-ffi/javascript/test/unit.test.ts

benalleng

TACK 777f16b Sorry it took so long, I know we got a bit caught up in rebase hell but lets try to keep focus when we are this close for so long before moving on to other stuff

Co-authored-by: Benalleng <benalleng@gmail.com>

spacebear21

utACK. I rebased to squash Ben's commit into the relevant 2nd commit, and added an additional commit that renames PrimitiveError to the more descriptive FfiValidationError

spacebear21 · 2026-02-17T16:38:48Z

payjoin-ffi/src/error.rs

 pub struct SerdeJsonError(#[from] serde_json::Error);

+#[derive(Debug, thiserror::Error, uniffi::Error)]
+pub enum PrimitiveError {


I think this type (and the PrimitiveError variants on specific error types) could be more descriptive as e.g. ValidationError or TypeCastError.

spacebear21 · 2026-02-17T18:02:02Z

payjoin-ffi/src/receive/error.rs

+    /// Amount exceeds allowed maximum.
+    #[error("Amount out of range: {amount_sat} sats (max {max_sat})")]
+    AmountOutOfRange { amount_sat: u64, max_sat: u64 },
+    /// Weight must be positive and no more than a block.
+    #[error("Weight out of range: {weight_units} wu (max {max_wu})")]
+    WeightOutOfRange { weight_units: u64, max_wu: u64 },


Seems these should just be part of the FfiValidation variant?

spacebear21

re-ACK b4a64e4

Rename error type and variants for clarity

spacebear21

re-re-ACK 0679a8c

I cleaned up the python checks which were false negatives before

benalleng

Re-ACK 0679a8c spacebear corrected a silent failure in the python integration test. This silent failure seems to be a common occurrence in python. we should explore how to better handle errors and warnings in python

chavic mentioned this pull request Jan 10, 2026

FFI primitive validation hardening + binding/test alignment #1262

Open

benalleng mentioned this pull request Jan 13, 2026

Test gap tracking issue #1264

Open

9 tasks

chavic force-pushed the chavic/primitives-validation branch 2 times, most recently from cd3391a to a44a282 Compare January 19, 2026 17:40

chavic force-pushed the chavic/primitives-validation branch 2 times, most recently from 59affc6 to 93bc4e8 Compare January 27, 2026 11:10

chavic force-pushed the chavic/primitives-validation branch 5 times, most recently from 055a2bb to 53db1cb Compare February 3, 2026 17:13

chavic requested review from DanGould, arminsabouri, benalleng and spacebear21 February 4, 2026 09:51

chavic marked this pull request as ready for review February 4, 2026 09:52

benalleng requested changes Feb 4, 2026

View reviewed changes

chavic force-pushed the chavic/primitives-validation branch from 759be1b to 10ee724 Compare February 4, 2026 14:35

chavic requested a review from benalleng February 4, 2026 14:38

chavic force-pushed the chavic/primitives-validation branch 8 times, most recently from 732c40a to f331ef3 Compare February 4, 2026 17:21

benalleng reviewed Feb 4, 2026

View reviewed changes

chavic force-pushed the chavic/primitives-validation branch 4 times, most recently from 8b3625e to 20d3670 Compare February 11, 2026 08:30

chavic removed the request for review from spacebear21 February 11, 2026 11:11

benalleng requested changes Feb 11, 2026

View reviewed changes

chavic force-pushed the chavic/primitives-validation branch 4 times, most recently from 5771b7a to c1c3600 Compare February 12, 2026 15:18

FFI sender validation and fee overflow guard

76eb6e5

chavic force-pushed the chavic/primitives-validation branch 2 times, most recently from 51d9f8b to 3f78b70 Compare February 16, 2026 12:52

benalleng reviewed Feb 16, 2026

View reviewed changes

payjoin-ffi/python/test/test_payjoin_unit_test.py Show resolved Hide resolved

benalleng reviewed Feb 16, 2026

View reviewed changes

payjoin-ffi/javascript/test/unit.test.ts Show resolved Hide resolved

benalleng approved these changes Feb 17, 2026

View reviewed changes

benalleng requested a review from spacebear21 February 17, 2026 15:01

chavic and others added 2 commits February 17, 2026 11:43

Binding primitive validation tests

aff2153

Co-authored-by: Benalleng <benalleng@gmail.com>

Align FFI tests with shared fixtures and polling

9fb307d

spacebear21 force-pushed the chavic/primitives-validation branch from 777f16b to 2b8e63e Compare February 17, 2026 17:31

spacebear21 approved these changes Feb 17, 2026

View reviewed changes

spacebear21 force-pushed the chavic/primitives-validation branch from 2b8e63e to edbe432 Compare February 17, 2026 17:56

spacebear21 reviewed Feb 17, 2026

View reviewed changes

spacebear21 force-pushed the chavic/primitives-validation branch from edbe432 to b4a64e4 Compare February 17, 2026 18:16

spacebear21 approved these changes Feb 17, 2026

View reviewed changes

s/PrimitiveError/FfiValidationError/g

0679a8c

Rename error type and variants for clarity

spacebear21 force-pushed the chavic/primitives-validation branch from b4a64e4 to 0679a8c Compare February 17, 2026 19:18

spacebear21 approved these changes Feb 17, 2026

View reviewed changes

benalleng approved these changes Feb 17, 2026

View reviewed changes

benalleng merged commit a27e1b7 into payjoin:master Feb 17, 2026
20 checks passed

Conversation

chavic commented Jan 10, 2026

Uh oh!

coveralls commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 22112284749

Details

💛 - Coveralls

Uh oh!

benalleng left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chavic commented Feb 4, 2026

Uh oh!

benalleng left a comment

Choose a reason for hiding this comment

Uh oh!

benalleng left a comment

Choose a reason for hiding this comment

Uh oh!

benalleng Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

chavic Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chavic Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

benalleng Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spacebear21 Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

benalleng left a comment

Choose a reason for hiding this comment

Uh oh!

spacebear21 left a comment

Choose a reason for hiding this comment

Uh oh!

spacebear21 Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

spacebear21 Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

spacebear21 left a comment

Choose a reason for hiding this comment

Uh oh!

spacebear21 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

benalleng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coveralls commented Jan 10, 2026 •

edited

Loading

benalleng left a comment •

edited

Loading

chavic Feb 12, 2026 •

edited

Loading

benalleng Feb 11, 2026 •

edited

Loading

spacebear21 left a comment •

edited

Loading