Skip to content

Conversation

@johannes-moegerle
Copy link
Contributor

merge after #17

@johannes-moegerle johannes-moegerle force-pushed the add-more-coupling-schemes branch from 34511a2 to 458aa86 Compare January 7, 2026 19:40
@johannes-moegerle johannes-moegerle changed the base branch from add-basis to v0.10a February 6, 2026 09:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for two additional angular momentum coupling schemes (JJ and FJ) to the rydstate library, expanding beyond the existing LS coupling for alkaline earth atoms. The PR introduces new Rydberg state classes and corresponding basis classes for these coupling schemes, along with tests to verify transformations between different coupling representations.

Changes:

  • Added RydbergStateSQDTAlkalineFJ and BasisSQDTAlkalineFJ classes for FJ coupling scheme
  • Added BasisSQDTAlkalineJJ class for JJ coupling scheme (state class already existed)
  • Refactored the nu calculation in RydbergStateSQDTAlkalineJJ to use a more concise list comprehension
  • Added tests for basis transformations between LS, JJ, and FJ coupling schemes

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/rydstate/rydberg/rydberg_sqdt.py Adds RydbergStateSQDTAlkalineFJ class for FJ coupling and refactors RydbergStateSQDTAlkalineJJ.nu calculation; adds AngularKetFJ import
src/rydstate/rydberg/init.py Exports new RydbergStateSQDTAlkalineFJ class
src/rydstate/basis/basis_sqdt.py Adds BasisSQDTAlkalineJJ and BasisSQDTAlkalineFJ classes for generating bases in JJ and FJ coupling schemes
src/rydstate/basis/init.py Exports new BasisSQDTAlkalineJJ and BasisSQDTAlkalineFJ classes
src/rydstate/init.py Exports new coupling scheme classes at the top level
tests/test_basis.py Adds test coverage for transformations between LS, JJ, and FJ coupling schemes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@johannes-moegerle johannes-moegerle merged commit 4c0f8c6 into v0.10a Feb 6, 2026
22 checks passed
@johannes-moegerle johannes-moegerle deleted the add-more-coupling-schemes branch February 6, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant