Open
Conversation
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
25 tasks
Created using spr 1.3.6-beta.1
sunshowers
commented
Dec 23, 2025
Comment on lines
-305
to
-309
| async fn v0_instance_ensure( | ||
| rqctx: RequestContext<Self::Context>, | ||
| request: TypedBody<api::v0::InstanceEnsureRequestV0>, | ||
| ) -> Result<HttpResponseCreated<api::InstanceEnsureResponse>, HttpError> | ||
| { |
Contributor
Author
There was a problem hiding this comment.
This code was replaced with a simpler From conversion.
sunshowers
commented
Dec 23, 2025
| /// | ||
| /// - `Some` if the VM has been created. | ||
| /// - `None` if no VM has ever been created. | ||
| pub(super) async fn v0_get(&self) -> Option<InstanceSpecGetResponseV0> { |
Contributor
Author
There was a problem hiding this comment.
This code becomes unnecessary now that the response type has a From implementation.
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In RFD 619, we've decided on a new way to organize published types; this PR makes the Propolis API conform to the RFD.