Skip to content

fix: cppcheck warnings in standalone/#3487

Closed
umprayz wants to merge 25 commits intoowasp-modsecurity:v2/masterfrom
umprayz:v2/cppcheck
Closed

fix: cppcheck warnings in standalone/#3487
umprayz wants to merge 25 commits intoowasp-modsecurity:v2/masterfrom
umprayz:v2/cppcheck

Conversation

@umprayz
Copy link

@umprayz umprayz commented Feb 1, 2026

what

  • This pull request fixes the cppcheck warnings in all .c, .cpp and .h files within the standalone directory.
  • The cppcheck command has been connected into the workflow.

why

  • The changes were made based on the result of cppcheck command and the built in checks of the workflow.
  • Previously, cppcheck could not find the necessary system and Apache headers, resulting in numerous "missing include" warnings and incorrect analysis.
  • With these changes, running cppcheck on the standalone directory now produces zero warnings locally and in CI.

references

  • The cppcheck configuration logic in Makefile.am was based on the v3/master branch.

notes

  • I would like to continue this work on other directories too and make the whole source tree cppcheck clean.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2026

@umprayz
Copy link
Author

umprayz commented Feb 4, 2026

Closing in favour of #3488, which is a cleaner version.

@umprayz umprayz closed this Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant