V3/do not add newline to test body lines#3486
Open
hnakamur wants to merge 21 commits intoowasp-modsecurity:v3/masterfrom
Open
V3/do not add newline to test body lines#3486hnakamur wants to merge 21 commits intoowasp-modsecurity:v3/masterfrom
hnakamur wants to merge 21 commits intoowasp-modsecurity:v3/masterfrom
Conversation
This is needed to test edge cases like a body missing the final newline, for example: [ "a\r\n", "b\r" ] And it is clearer than to add implicit newline to each line except the final line.
when UPDATE_CONTENT_LENGTH env var is set
by running the following command: ``` (cd test; ./regression_tests format) ```
by running the following command: ``` (cd test; UPDATE_CONTENT_LENGTH=1 ./regression_tests format) ```
8fefe12 to
9b49187
Compare
Contributor
Author
|
I found JSON was corrupted since some of http_version was empty. I fixed it and force pushed. |
Contributor
Author
|
I fixed tests at aefd4a4 and now all tests pass again. |
Member
|
Hi @hnakamur, thank you for this improved PR. Unfortunately there are two warnings from cppcheck: Also, SonarCloud reported a few new issues (some of them are same as As I mentioned previously, I don't expect to fix all Sonar issues. If the Thank you again. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



what
formatsubcommand toregression_testscommand.Content-Lengthheader by running(cd test; UPDATE_CONTENT_LENGTH=1 ./regression_tests format)why
references