Fix ls command to properly list services by name#53
Draft
Conversation
- Fixed cli.js to call list.prs() instead of ps.prs() for service name filtering - Improved list.js to use docker service ls -f name=<name> without grep - Added unit tests to verify the correct docker commands are generated - Resolves issue #9: [CMD] list all and specific service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Issue #9: [CMD] list all and specific service
Problem
The
orcinus ls [service name]command was incorrectly callingps.prs()which shows service tasks/processes instead of service status. This didn't match the expected behavior described in the issue.Solution
Fixed CLI routing: Changed
cli.jsline 122 fromps.prs(program.ls)tolist.prs(program.ls)to properly route service name filtering to the list module.Improved service filtering: Updated
list.jsto usedocker service ls -f 'name=<name>'directly instead of piping through grep, which matches the behavior shown in the issue comment.Added tests: Created unit tests to verify the correct docker commands are generated for both specific service filtering and listing all services.
Changes Made
cli.js: Fixed routing for service name filteringlib/list.js: Simplified service filtering commandtest/test-list.js: Added unit tests for list functionalityTesting
Fixes #9