Skip to content

Conversation

@ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Jan 27, 2026

Use lowercase for variable names within functions.

Summary by CodeRabbit

  • Style

    • Standardized variable naming conventions throughout the codebase to align with Python best practices.
  • Chores

    • Updated linting configuration to enforce stricter naming rules for improved code consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

Walkthrough

The pull request applies variable naming convention updates across the codebase to enforce lowercase naming for variables within functions. Changes include renaming uppercase-formatted logging variables (FORMAT to format_str) in multiple control modules, refactoring internal constants in the GraphQL renderer (FILTERS_KEY, ALIAS_KEY, KEYWORDS_TO_SKIP to lowercase equivalents), and updating variable names in utilities and test files. Additionally, the Ruff linter configuration is updated to remove the N806 exception, activating the "Variable in function should be lowercase" rule to enforce these naming conventions going forward.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 57.14% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Prefer variables in lowercase' accurately and directly summarizes the main objective of the changeset, which involves renaming uppercase variable names to lowercase across multiple files in response to enabling the N806 Ruff linting rule.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: c9d8342
Status: ✅  Deploy successful!
Preview URL: https://e15f70d9.infrahub-sdk-python.pages.dev
Branch Preview URL: https://pog-n806.infrahub-sdk-python.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/ctl/check.py 0.00% 2 Missing ⚠️
infrahub_sdk/ctl/cli_commands.py 0.00% 2 Missing ⚠️
@@           Coverage Diff           @@
##           stable     #771   +/-   ##
=======================================
  Coverage   80.39%   80.39%           
=======================================
  Files         115      115           
  Lines        9872     9872           
  Branches     1513     1513           
=======================================
  Hits         7937     7937           
  Misses       1413     1413           
  Partials      522      522           
Flag Coverage Δ
integration-tests 41.39% <64.70%> (ø)
python-3.10 51.45% <76.47%> (ø)
python-3.11 51.45% <76.47%> (ø)
python-3.12 51.45% <76.47%> (ø)
python-3.13 51.45% <76.47%> (ø)
python-3.14 53.08% <76.47%> (-0.03%) ⬇️
python-filler-3.12 24.04% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/ctl/utils.py 68.53% <100.00%> (ø)
infrahub_sdk/graphql/renderers.py 92.85% <100.00%> (ø)
infrahub_sdk/utils.py 88.53% <100.00%> (ø)
infrahub_sdk/ctl/check.py 26.44% <0.00%> (ø)
infrahub_sdk/ctl/cli_commands.py 71.20% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogenstad ogenstad marked this pull request as ready for review January 27, 2026 08:52
@ogenstad ogenstad requested a review from a team as a code owner January 27, 2026 08:52
@ogenstad ogenstad merged commit 2f06924 into stable Jan 27, 2026
21 checks passed
@ogenstad ogenstad deleted the pog-N806 branch January 27, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants