Skip to content

Conversation

@ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Jan 26, 2026

Fix linting exceptions and a very slight performance improvement. :)

Summary by CodeRabbit

  • Refactor

    • Consolidated internal code structure across multiple modules for improved maintainability.
  • Style

    • Re-enabled code style linting enforcement to maintain quality standards.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 26, 2026

Walkthrough

This pull request refactors code in two files to consolidate list operations. In infrahub_sdk/graphql/query.py, the closing braces in Mutation.render are now added via a single extend() call instead of separate append() calls. Similarly, infrahub_sdk/spec/range_expansion.py consolidates tuple appending in the _extract_constants function using extend(). Additionally, the FURB113 linter ignore rule is removed from pyproject.toml, re-enabling this linting check.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: refactoring multiple .append() calls to use .extend() instead, which aligns with the PR objectives and file-level changes across the codebase.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 106e2bf
Status: ✅  Deploy successful!
Preview URL: https://630f919f.infrahub-sdk-python.pages.dev
Branch Preview URL: https://pog-furb113.infrahub-sdk-python.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##           stable     #769      +/-   ##
==========================================
- Coverage   80.39%   80.38%   -0.01%     
==========================================
  Files         115      115              
  Lines        9879     9877       -2     
  Branches     1513     1513              
==========================================
- Hits         7942     7940       -2     
  Misses       1415     1415              
  Partials      522      522              
Flag Coverage Δ
integration-tests 41.40% <50.00%> (-0.02%) ⬇️
python-3.10 51.45% <100.00%> (-0.01%) ⬇️
python-3.11 51.45% <100.00%> (-0.01%) ⬇️
python-3.12 51.45% <100.00%> (+0.01%) ⬆️
python-3.13 51.45% <100.00%> (-0.01%) ⬇️
python-3.14 53.09% <100.00%> (-0.01%) ⬇️
python-filler-3.12 24.02% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/graphql/query.py 100.00% <100.00%> (ø)
infrahub_sdk/spec/range_expansion.py 88.40% <100.00%> (-0.17%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogenstad ogenstad marked this pull request as ready for review January 26, 2026 15:24
@ogenstad ogenstad requested a review from a team as a code owner January 26, 2026 15:24
@ogenstad ogenstad merged commit f1d6479 into stable Jan 26, 2026
21 checks passed
@ogenstad ogenstad deleted the pog-FURB113 branch January 26, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants