dns/ddclient hetzner existing record update patch

[jnikodemus]

Fix ddclient update Hetzner for new API
Reference
pull#5082
issue#5187

Problem
The actual update method returns code 200 for an update, because it doesnt use the right entrypoint.

Fix
Changed the API entrypoint "actions" and removed code duplication.

Testing
Tested on a local OPNsense instance with multiple records.

[AdSchellevis]

wouldn't it be better to open a ticket at their end, it feels rather weird to patch the caller in this case (assuming its a bug and not a documented change of behavior)

[jnikodemus]

You are right, I've contacted the hoster again. I'll write it correct.

[Ollienator]

I was just going to open a pull request for the same issue but then I found yours. Since you also removed some code duplication, your changes are ahead of mine (see 7bc1af4).

One thing I have noticed is that you are including the TTL parameter in your request. This should be removed as it's not used in the update_records action (see https://docs.hetzner.cloud/reference/cloud#tag/zone-rrset-actions/update_zone_rrset_records).

[jnikodemus]

I was just going to open a pull request for the same issue but then I found yours. Since you also removed some code duplication, your changes are ahead of mine (see 7bc1af4).

One thing I have noticed is that you are including the TTL parameter in your request. This should be removed as it's not used in the update_records action (see https://docs.hetzner.cloud/reference/cloud#tag/zone-rrset-actions/update_zone_rrset_records).

Thank you, appreciate the hint. I've removed the ttl from the _update_record and tested again -> success.