EXCH-10878 Native support for OpenX bidder#10
Closed
Conversation
Author
|
places we can think about additional tests:
|
bukrain
reviewed
Dec 27, 2024
src/test/resources/org/prebid/server/it/openrtb2/openx/test-native-response.json
Outdated
Show resolved
Hide resolved
sergseven
commented
Dec 27, 2024
| } | ||
|
|
||
| @Test | ||
| public void openrtb2AuctionWithNativeShouldRespondWithBidsFromOpenx() throws IOException, JSONException { |
Author
There was a problem hiding this comment.
note: we are considering removing this test case since it seems to be duplicated with the unit tests and it looks like this test level is not dedicated to test the features, but integration only
gmiedlar-ox
reviewed
Dec 30, 2024
gmiedlar-ox
left a comment
There was a problem hiding this comment.
According to our recent conversation, maybe it would be worth to add a test case verifying what will be returned from makeHttpRequest when there is multi-ad-placement imp in bid request?
gmiedlar-ox
approved these changes
Dec 30, 2024
Author
|
merged to the mainstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
having the PR here to have the checks running