fix: disable wallet history command due to Taostats API changes (#235) #808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add the print_success util * feat: refactor with print_success * fix: update with print_success and print_error * ruff format * fix: revert cli * fix: update the util for print_success * fix: update the print_error and revert print_success for remove.py file * hotfix: add the missing character * fix: change to white_check_mark * fix: revert to white_heavy_check_mark * fix: revert print_success for wallet and few consol from utils * ruff format * fix: revert in the e2e util * ruff format
…e-test Update User Liquidity E2E test
updated proxy help text
…CallDelay-constant-name Update DurationOfStartCall -> InitialStartCallDelay
…afe-staking Feat: Add protection warnings
…-enhancements feat: Add crowdloan contributors command and enhance create/view functionality
Fixes opentensor#635 ## Problem Running `btcli subnets list --json-out` produced no output. ## Root Cause In `dict_table()` function, `tao_flow_ema` was already converted to a float via `.tao`, but line 604 tried to call `.tao` again, causing an `AttributeError: 'float' object has no attribute 'tao'`. This error was silently swallowed, resulting in empty output. ## Changes 1. `subnets.py`: Fixed double `.tao` call on `tao_flow_ema` 2. `utils.py`: Changed `json_console` to use `force_terminal=True` to ensure output in all environments ## Testing - Verified `btcli subnets list --json-out` now produces valid JSON output - Tested with Python 3.12, BTCLI 9.17.0, finney network
Changelog: 9.18.0
…cation-and-bugs Fix: Mech count indication + missing params
Updates changelog for 9.18.0
Contributor
|
Thank you for your contrib! Also I would change the message up a bit to something like "This command is currently disabled as it used external APIs which are no longer feasible; meanwhile a chain native data fetching solution is being investigated" |
Author
|
what about this @ibraheem-abe ?
Commit |
Contributor
|
@jose-blockchain And also please base your branch on top of latest staging - we dont merge directly to main |
…empty fix: JSON output empty for `btcli subnets list --json-out` command
This command is disabled as it used external APIs which are no longer feasible; meanwhile a chain native data fetching solution is being investigated. Fixes opentensor#235 Related to opentensor#302
jose-blockchain
force-pushed
the
fix/disable-wallet-history-235
branch
from
c4ba7c0 to
78ca077
Compare
Author
|
ok created a new PR here @ibraheem-abe #811 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disables the
wallet historycommand which is currently broken due to the Taostats API(
https://api.subquery.network/sq/TaoStats/bittensor-indexer) returning 404 errors.The API now requires an API key which cannot be feasibly bundled with btcli.
The command now displays an informative message to users explaining the situation and
linking to the tracking issue.
Changes
wallet_history()inbittensor_cli/src/commands/wallets.pyto displaya disabled message instead of attempting the broken API call
Fixes
btcli w historywith new endpoint #302Potential Reviewers
@thewhaleking @distributedstatemachine @ibraheem-abe