-
Notifications
You must be signed in to change notification settings - Fork 213
Revert "OTA-1604: migrate ocp-46922 from otp to cvo repo" #1297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@neisw: This pull request references OTA-1604 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThe changes remove cluster-dependent test code and utilities from the CVO test suite. A test entry is deleted from the extension manifest, a large live-cluster test block is removed from cvo.go, and the entire util.go file containing Kubernetes and OpenShift client initialization functions is deleted. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes ✨ Finishing touches
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: neisw The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@neisw: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
Reverts #1279
Tracked in TRT-2511
Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.
Multiple payload failures due to microshift failures for cluster-version-operator should have correct runlevel and scc`
To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Payload testing microshift may not be possible in your PR please review the failure and address the issue.
CC: @jiajliu @hongkailiu