[WIP] Twig extension testing, fix nontype collections#43
[WIP] Twig extension testing, fix nontype collections#43dbu wants to merge 3 commits intoopenpsa:masterfrom dbu:fix-nontype-collections
Conversation
|
Hi, just a quick comment: travis says the tests fail for this because some doctrine stuff can't be found: so it seems composer.json or something has to be updated. I wonder if composer supports conditional dependencies, but well, for the moment we can make do with the dev switch |
|
yes, would be a typical case for --dev. the optional stuff is handled with suggest and up to the user whether he wants to include suggestions in his main composer.json. i will investigate this when i find time again to work on it, not sure how soon that can happen. |
|
what is done here is fixed in #46 too. the only issue are the nontype collections of tags where i still miss an example of how the tag plugin of create.js works |
|
i will update this branch once #46 has been merged and see what is still relevant. |
this tries to address #37
unfortunately, i still don't know how to really handle string tags and would need somebody to experiment with the minimum required thing to use the createjs tag plugin for them and see if we can inline such tags with the main entity in some way or not.