refactor: enhanced Join Private Lobby form#3284
Open
Nonolanlan1007 wants to merge 1 commit intoopenfrontio:mainfrom
Open
refactor: enhanced Join Private Lobby form#3284Nonolanlan1007 wants to merge 1 commit intoopenfrontio:mainfrom
Nonolanlan1007 wants to merge 1 commit intoopenfrontio:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request enhances the
JoinLobbyModalcomponent by using the<form>component and the@submitevent. It allows the user to use the enter (return) key to submit instead of grabbing its mouse to click on "Join Lobby".It also introduces a new
submitargument to theButtoncomponent.Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
@nolhan__
PS: The tests from
tests/InputHandler.test.tsare failing on bothmainand my branch. EDIT: They no longer fail through the workflow so I guess I didn't have the correct environment