security: add IP-based login throttling #710
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple brute-force protection for the OpenCATS login by rate-limiting failed login attempts per IP address.
If an IP address has more than 10 failed login attempts within the last 10 minutes, further login attempts from that IP are blocked early (before any credential validation) and a generic error message is shown.
To prevent bypassing the IP throttle by trying random usernames, failed attempts for unknown usernames are now also written to
user_login(withuser_id = NULLandsite_id = 0).