-
Notifications
You must be signed in to change notification settings - Fork 289
feat: add required-field support for additional careers portal inputs #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anonymoususer72041
wants to merge
14
commits into
opencats:master
Choose a base branch
from
anonymoususer72041:feature/careers-required-fields
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add required-field support for additional careers portal inputs #677
anonymoususer72041
wants to merge
14
commits into
opencats:master
from
anonymoususer72041:feature/careers-required-fields
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonymoususer72041
added a commit
to anonymoususer72041/OpenCATS
that referenced
this pull request
Dec 11, 2025
opencats#677 commit bce532d Author: anonymoususer72041 <247563575+anonymoususer72041@users.noreply.github.com> Date: Fri Dec 5 15:57:52 2025 +0100 Add comments in careers apply validator commit 47bef29 Author: anonymoususer72041 <247563575+anonymoususer72041@users.noreply.github.com> Date: Fri Dec 5 15:55:32 2025 +0100 Add required support for additional careers portal input fields commit 1176778 Author: anonymoususer72041 <247563575+anonymoususer72041@users.noreply.github.com> Date: Fri Dec 5 14:54:37 2025 +0100 Drop legacy address2 from candidates add form commit e187c3d Author: anonymoususer72041 <247563575+anonymoususer72041@users.noreply.github.com> Date: Fri Dec 5 10:52:02 2025 +0100 Use single-line address input in careers portal apply form commit 44320d6 Author: anonymoususer72041 <247563575+anonymoususer72041@users.noreply.github.com> Date: Fri Dec 5 09:04:02 2025 +0100 Use single-line address inputs for candidates, contacts and companies
Contributor
Author
|
This Pull Request also addresses issue #354. |
RussH
reviewed
Jan 26, 2026
Member
RussH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bce532d to
30096f4
Compare
30096f4 to
1e26992
Compare
Contributor
Author
@RussH done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note about dependency on #675
This Pull Request is currently stacked on top of #675.
The overlap is mainly about the address field:
<input>elements with a consistentid="address", including the careers portal apply templates._makeApplyValidator()assumes that<input-address>renders an element withid="address"so that<input-address req>can be validated safely.Summary
Extend
_makeApplyValidator()inmodules/careers/CareersUI.phpso more input placeholders can be configured as required via thereqmarker in the careers portal template:Motivation
OpenCATS already supports a small set of required fields in the careers portal by looking for markers like
<input-address req>in the template and generating a JavaScriptapplyValidate()function accordingly.However, a number of input placeholders were not "req-aware" and could not be configured as required fields even though they are important in real-world setups (e.g. mobile phone number or resume upload).
This Pull Request extends the existing mechanism in a backwards-compatible way so that careers portal templates can opt into stricter validation where needed by simply adding the
reqmarker to the relevant placeholders.