Merged
Conversation
jack-berg
reviewed
Jan 28, 2026
| id: otelbot-token | ||
| with: | ||
| app-id: ${{ vars.OTELBOT_SEMANTIC_CONVENTIONS_JAVA_APP_ID }} | ||
| private-key: ${{ secrets.OTELBOT_SEMANTIC_CONVENTIONS_JAVA_PRIVATE_KEY }} |
Member
There was a problem hiding this comment.
Where do these come? Are they org level vars / secrets?
Member
Author
There was a problem hiding this comment.
jack-berg
reviewed
Jan 28, 2026
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read |
Member
There was a problem hiding this comment.
How does this get away with read permissions?
Member
Author
There was a problem hiding this comment.
these are permissions for the default GITHUB_TOKEN
and this script is using OTELBOT_SEMANTIC_CONVENTIONS_JAVA_APP_ID for all of it's permissions
jack-berg
approved these changes
Jan 28, 2026
Member
Author
|
🤞 we'll find out if this works after the next semconv release... 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modeled after https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/.github/workflows/auto-update-otel-sdk.yml