Declarative config authenticator PoC#7605
Declarative config authenticator PoC#7605zeitlinger wants to merge 14 commits intoopen-telemetry:mainfrom
Conversation
|
|
||
| @Override | ||
| public SpanExporter create(DeclarativeConfigProperties config) { | ||
| public SpanExporter create(DeclarativeConfigProperties config, ComponentProviderLoader componentProviderLoader) { |
There was a problem hiding this comment.
I think the vision was that you would be able to use DeclarativeConfigProperties.getComponentLoader()?
There was a problem hiding this comment.
this is a different type of loader - it's specifically for declarative config components - so it should probably called that way
The underlying problem is that the exporters need to be able to create a declarative component
c16fafd to
67e16e1
Compare
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (75.60%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7605 +/- ##
============================================
- Coverage 89.99% 89.96% -0.04%
- Complexity 7079 7092 +13
============================================
Files 803 805 +2
Lines 21419 21452 +33
Branches 2086 2089 +3
============================================
+ Hits 19276 19299 +23
- Misses 1479 1488 +9
- Partials 664 665 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Based on open-telemetry/opentelemetry-configuration#275
PoC implementation for open-telemetry/opentelemetry-configuration#257
Spec issue: open-telemetry/opentelemetry-specification#1344