Add arch test to detect usage of shared internal code#6978
Open
jack-berg wants to merge 10 commits intoopen-telemetry:mainfrom
Open
Add arch test to detect usage of shared internal code#6978jack-berg wants to merge 10 commits intoopen-telemetry:mainfrom
jack-berg wants to merge 10 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6978 +/- ##
=========================================
Coverage 90.15% 90.15%
Complexity 7476 7476
=========================================
Files 836 836
Lines 22550 22550
Branches 2224 2224
=========================================
Hits 20331 20331
Misses 1515 1515
Partials 704 704 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Resurrecting this and marking ready for review @open-telemetry/java-approvers. There have been a number of topics coming up lately that reinforce the need to avoid shared internal code. A couple that come to mind:
|
jack-berg
commented
Jan 9, 2026
| "opentelemetry-exporter-otlp-common", | ||
| "opentelemetry-exporter-sender-grpc-managed-channel", | ||
| "opentelemetry-exporter-sender-jdk", | ||
| "opentelemetry-exporter-sender-okhttp")); |
Member
Author
There was a problem hiding this comment.
Here's the TODO list. All these modules use shared internal code.
In contrast, the list of modules which DO NOT use shared internal code is small:
opentelemetry-commonopentelemetry-contextopentelemetry-tracing-shimopentelemetry-apiopentelemetry-extension-kotlinopentelemetry-sdk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #6970.
This test prints out instances of shared internal code use. We could eventually remove all the detected instances, at which point we could fail the build instead of just printing.
But there's a long way to go. See this gist for the current state of affairs.
Note: I don't currently have a good way to tell when internal code is referenced for things like the SDK's implementation of of
opentelemetry-api-incubating, which is switched to a compile dependency in #6944.