Adding a cmake option to exclude the jsoncpp files from install.#1596
Open
nv-jdeligiannis wants to merge 4 commits intoopen-source-parsers:masterfrom
Open
Adding a cmake option to exclude the jsoncpp files from install.#1596nv-jdeligiannis wants to merge 4 commits intoopen-source-parsers:masterfrom
nv-jdeligiannis wants to merge 4 commits intoopen-source-parsers:masterfrom
Conversation
…ul when used used as a submodule
Author
|
Please let me know if I need to make anything else to get this reviewed. Thanks! |
baylesj
reviewed
Mar 12, 2025
Contributor
baylesj
left a comment
baylesj
left a comment
There was a problem hiding this comment.
Have a minor tweak, otherwise looks good!
| option(JSONCPP_WITH_PKGCONFIG_SUPPORT "Generate and install .pc files" ON) | ||
| option(JSONCPP_WITH_CMAKE_PACKAGE "Generate and install cmake package files" ON) | ||
| option(JSONCPP_WITH_EXAMPLE "Compile JsonCpp example" OFF) | ||
| option(JSONCPP_WITH_INSTALL "Include JsonCpp header and binaries in the install target" ON) |
Contributor
There was a problem hiding this comment.
Nit: name could use a tweak, I think. Maybe JSONCPP_WITH_INSTALL_TARGET or JSONCPP_ENABLE_INSTALL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful when managing submodules