First try #1130
Open
First try #1130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
artn-odoo
reviewed
Jan 20, 2026
artn-odoo
left a comment
artn-odoo
left a comment
There was a problem hiding this comment.
Looks good so far !
All there is to say are small styling nitpicks, but the tests won't pass if they are not fixed.
We try to always leave an empty line at the end of a file, if you are using vscode, this can be done automatically by checking the Insert Final Newline option.
We also have pretty strict guidelines for the commit name and definition, which can be found here. https://www.odoo.com/documentation/16.0/contributing/development/git_guidelines.html
Co-authored-by: Arthur Nanson <artn@odoo.com>
Co-authored-by: Arthur Nanson <artn@odoo.com>
This addition will allow to make the newly created model usable through the Odoo frontend and to validate access rights and views integration.
This commit enhances the estate.property model by introducing reserved fields and field attributes required in the UI.
The default auto-generated views are not suitable for real usage. This change provides a clearer and more efficient UI for users by presenting the key information in a structured way and enabling faster retrieval of relevant properties via dedicated search options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.