-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[ADD] estate: create a new module for Real Estate Advertisement #1127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
Creation of a new module estate that covers Real Estate Advertisement. There is no module that answer this business case by default.
This adds property model to the estate module with the objective to store the informations related to the property.
This adds fields to store information related to the property (name, description, price, living area…)
artn-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job so far !
We always try to add a new line at the end of every file, for it to be easier to read.
This can be done automatically if you are using vscode by turning on the Insert Final Newline option in the settings.
estate/models/property.py
Outdated
| _name = "estate_property" | ||
| _description = "estate property" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't have to change it all, but we prefer using single quotes in Python files unless using double is required for some semantic reasons.
|
|
||
| class EstateProperty(models.Model): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We prefer adding 2 blank lines before declaring a class.
| class EstateProperty(models.Model): | |
| class EstateProperty(models.Model): |
This add a new line at the end of every file to be easier to read. This changes strings defined by double quotes to strings with single quotes. This also uses two blank lines instead of one before declaring a class
This gives access rights to the group base.group_user. This is needed because no access rights was defined so no users can access the data.
This creates a 3 levels architecture with an action to interact with property model.
This changes attributes of selling price to read-only and prevents the copy of availability date and selling price fields.
This adds a default value for the bedrooms and the availability date. This also add an active and a state field.
This cleans the code based on robodoo recommendations by removing some lines and correcting wrong indentations.
This adds new column names to the list view and a new form view according to the required specifications.
This creates new search fields, a filter for available properties and the possibility to group the properties by postcode.
This creates a new module for the type of a property. The type of a property record can be observerd in list and form views.

Creation of a new module estate that covers Real Estate Advertisement. There is no module that answer this business case by default.