Estate module declaration and models #1126

mohamedakhalil18 · 2026-01-19T14:50:23Z

No description provided.

robodoo · 2026-01-19T14:50:26Z

artn-odoo

Good job so far, just a few styling nitpicks but it's good overall !
We try to always add a newline at the end of a file. This can be done by activating the Insert Final Newline if you are using vscode.
Also, we have pretty strict guidelines regarding the commit titles and message. You can find them here for future commits https://www.odoo.com/documentation/16.0/contributing/development/git_guidelines.html

artn-odoo · 2026-01-20T09:13:45Z

estate/__manifest__.py

+    'version':'1.0',
+    'summary':'Track advertisements added for real estate and allow selling them',
+    'website':'https://www.odoo.com/app/estate',
+    'depends':[
+        'base'
+        ],
+    'application':True,
+    'installable':True,
+    'author':'moali',
+    'license':'LGPL-3'


Try to leave a white space after :

Suggested change

'version':'1.0',

'summary':'Track advertisements added for real estate and allow selling them',

'website':'https://www.odoo.com/app/estate',

'depends':[

'base'

],

'application':True,

'installable':True,

'author':'moali',

'license':'LGPL-3'

'version':' 1.0',

'summary': 'Track advertisements added for real estate and allow selling them',

'website': 'https://www.odoo.com/app/estate',

'depends': [

'base'

],

'application': True,

'installable': True,

'author': 'moali',

'license': 'LGPL-3'

artn-odoo · 2026-01-20T09:16:19Z

estate/models/estate_property.py

+    _name = 'estate_property'
+    _description = 'Estate Property'
+
+    name = fields.Char(string = "Property Name", required = True)


We try not to put white spaces around the = sign in function calls or function definitions.
The same can be said for all the fields below.

Suggested change

name = fields.Char(string = "Property Name", required = True)

name = fields.Char(string="Property Name", required=True)

mohamedakhalil18 · 2026-01-20T10:24:02Z

I have created a new commit with the formatted code

…m and list views

csan-odoo

Great work overall! Just a few minor adjustments needed. Also:

When defining view names, please follow the usual Odoo convention by using dot notation (e.g., module.view_name).
Make sure to include any unnecessary files in the .gitignore to keep the repository clean.

Thanks!

csan-odoo · 2026-01-21T09:16:23Z

awesome_dashboard/controllers/__init__.py

 # -*- coding: utf-8 -*-

-from . import controllers
+from . import controllers


be sure to always leave an empty line at the end of each file

csan-odoo · 2026-01-21T09:18:32Z

awesome_owl/__init__.py

 # -*- coding: utf-8 -*-

-from . import controllers
+from . import controllers


same as above

csan-odoo · 2026-01-21T09:19:04Z

awesome_owl/controllers/__init__.py

 # -*- coding: utf-8 -*-

-from . import controllers
+from . import controllers


same as above

csan-odoo · 2026-01-21T09:23:04Z

estate/__init__.py

The init.py file is used to load Python code only, so there’s no need to import security files or XML views there. Those are handled through the module manifest instead.

csan-odoo · 2026-01-21T09:40:52Z

estate/security/ir.model.access.csv

@@ -0,0 +1,2 @@
+id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
+1,access_estate_property,model_estate_property,base.group_user,1,1,1,1


as an external ID for an access record, it’s generally best to use a descriptive name because it makes the record easier to read and usually more stable over time.

csan-odoo · 2026-01-21T09:43:28Z

estate/views/form_views.xml

+        <field name="name">Property Form</field>
+        <field name="model">estate.property</field>
+        <field name="arch" type="xml">
+            <form string="property">


Suggested change

<form string="property">

<form>

csan-odoo · 2026-01-21T09:47:50Z

estate/views/form_views.xml

+                            <field name="postcode" string="Postcode"/>
+                            <field name="date_availability"/>
+                        </group>
+                        <group>
+                            <field name="expected_price" string="Expected Price"/>
+                            <field name="selling_price" string="Selling Price"/>
+                        </group>
+                    </group>
+                    <notebook>
+                        <page string="Details">
+                            <group>
+                                <group>
+                                    <field name="description" string="Description"/>
+                                    <field name="bedrooms" string="Bedrooms"/>
+                                    <field name="living_area" string="Living Area (sqm)"/>
+                                    <field name="facades" string="Facades"/>
+                                    <field name="garage"/>
+                                    <field name="garden"/>
+                                    <field name="garden_area"/>
+                                    <field name="garden_orientation"/>


Nitpick
When you declare a field, Odoo automatically creates a default label by capitalizing the first letter. If this matches what you want to display, there’s no need to set the string manually.

csan-odoo · 2026-01-21T09:55:04Z

estate/views/search_views.xml

+        <field name="name">Property Search</field>
+        <field name="model">estate.property</field>
+        <field name="arch" type="xml">
+            <search string="property">


Suggested change

<search string="property">

<search>

csan-odoo · 2026-01-21T09:56:36Z

estate/views/search_views.xml

+                <group expand="1" string="Postcode">
+                    <filter string="Postcode" name="postcode_group" context="{'group_by':'postcode'}"/>
+                </group>
+                <!-- <filter string="Archived" name='active' domain="['!',('active','=',True)]"/> -->


Suggested change

Estate Included related fields in order to allow the communication between the estate property base model and tags, types, offers, users, and partners model to extend the funcationalities of the current module to cater for the business need of having specific sales info. for each record

Estate Added computation fields and onchange methods to facilitate data entry for each user and incorporate automation that computes best offer - garden orientation and area - validity dates and deadlines

Estate Added action buttons to sell/cancel an apartment and accept or refuse a given offer. The added actions and functionalities are aiming to provide the user of the estate app with more flexible actions in order to complete their tasks of selling or cancelling real estate listings as well as accepting or refusing any given offer against that listing. Moreover, accepting an offer will automatically sell the listing to that bidder

Estate module declaration and models

058a836

mohamedakhalil18 requested a review from artn-odoo January 19, 2026 14:50

artn-odoo reviewed Jan 20, 2026

View reviewed changes

added linting and formatting

6de9b37

mohamedakhalil18 added 3 commits January 20, 2026 13:10

Added access control to my module

e1cc948

Added action and menus to enable user to add properties

3a2bc4d

Added search, filtering, grouping functionalities and reformatted for…

e5fd859

…m and list views

artn-odoo requested a review from csan-odoo January 21, 2026 08:57

csan-odoo requested changes Jan 21, 2026

View reviewed changes

artn-odoo requested review from artn-odoo and removed request for artn-odoo January 21, 2026 10:12

mohamedakhalil18 added 3 commits January 21, 2026 13:52

[IMP]

6d86c68

Estate Added computation fields and onchange methods to facilitate data entry for each user and incorporate automation that computes best offer - garden orientation and area - validity dates and deadlines

	name = fields.Char(string = "Property Name", required = True)
	name = fields.Char(string="Property Name", required=True)

		@@ -0,0 +1,2 @@
		id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
		1,access_estate_property,model_estate_property,base.group_user,1,1,1,1

Estate module declaration and models #1126

Are you sure you want to change the base?

Estate module declaration and models #1126

Uh oh!

Conversation

mohamedakhalil18 commented Jan 19, 2026

Uh oh!

robodoo commented Jan 19, 2026

Uh oh!

artn-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mohamedakhalil18 commented Jan 20, 2026

Uh oh!

csan-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

csan-odoo Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

csan-odoo Jan 21, 2026 •

edited

Loading