Skip to content

Comments

imageRetention for build#1214

Merged
alexcos20 merged 1 commit intomainfrom
feature/imageRetention_build
Feb 20, 2026
Merged

imageRetention for build#1214
alexcos20 merged 1 commit intomainfrom
feature/imageRetention_build

Conversation

@alexcos20
Copy link
Member

@alexcos20 alexcos20 commented Feb 20, 2026

Changes proposed in this PR:

  • do not delete image built on cleanup, but let them be handled by imageRetetion algo
  • add missing deleteImage, so we can delete the record fromdb

@alexcos20
Copy link
Member Author

/run-security-scan

Copy link
Member Author

@alexcos20 alexcos20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI automated code review (Gemini 3).

Overall risk: low

Summary:
This pull request refactors and enhances the Docker image lifecycle management within the C2D engine. It integrates a new database function deleteImage to ensure consistency between Docker images and their records in the C2D database upon removal. Additionally, it ensures that newly built Docker images are tracked for usage, which is crucial for the new image retention policy. An older, less comprehensive image deletion mechanism has been removed, streamlining the cleanup process.

Comments:
• [INFO][style] This block of code for deleting algorithm images has been removed. Please confirm that the new image retention policy and associated cleanup mechanisms fully supersede and robustly handle all scenarios previously covered (or intended to be covered) by this logic. This seems like a positive simplification if the new system is comprehensive.
• [WARNING][performance] The catch block for updateImageUsage logs a debug message. If tracking image usage is critical for the image retention policy to function correctly (e.g., preventing old images from being deleted if their usage wasn't tracked), failing to track usage might be a more significant issue than a debug-level log suggests. Consider changing this to CORE_LOGGER.warn or CORE_LOGGER.error to ensure better visibility if this essential tracking mechanism fails consistently.
• [INFO][other] The deleteImage implementation for SQLite looks correct and follows existing patterns for database operations. Good use of Promises and logging for clarity.

@alexcos20 alexcos20 marked this pull request as ready for review February 20, 2026 05:34
@alexcos20 alexcos20 merged commit d488b1f into main Feb 20, 2026
12 checks passed
@alexcos20 alexcos20 deleted the feature/imageRetention_build branch February 20, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants