Merged
Conversation
✅ Deploy Preview for oasisprotocol-cli canceled.
|
uniyalabhishek
force-pushed
the
uniyalabhishek/feature/format-known-addresses-131
branch
from
0068b35 to
95ace6e
Compare
Member
|
This would be nice addition. @uniyalabhishek can you rebase? @matevz can you review please? |
Contributor
Author
@ptrus sorry, this PR is not fully ready for review now (also oasisprotocol/oasis-sdk#2335). there have been higher-priority tasks and missed completing this. will prioritise it this week. |
uniyalabhishek
force-pushed
the
uniyalabhishek/feature/format-known-addresses-131
branch
from
95ace6e to
ee0dbb3
Compare
Member
|
FYI I'll be refactoring |
uniyalabhishek
force-pushed
the
uniyalabhishek/feature/format-known-addresses-131
branch
2 times, most recently
from
c451ac0 to
a2b7ccc
Compare
uniyalabhishek
requested review from
matevz,
peternose and
ptrus
and removed request for
matevz and
peternose
matevz
reviewed
Jan 23, 2026
Member
matevz
left a comment
matevz
left a comment
There was a problem hiding this comment.
First pass. IMO we should simplify more.
uniyalabhishek
force-pushed
the
uniyalabhishek/feature/format-known-addresses-131
branch
from
a2b7ccc to
f0e7240
Compare
matevz
reviewed
Jan 29, 2026
uniyalabhishek
force-pushed
the
uniyalabhishek/feature/format-known-addresses-131
branch
2 times, most recently
from
197a1ee to
d0a2549
Compare
matevz
approved these changes
Feb 3, 2026
Member
matevz
left a comment
matevz
left a comment
There was a problem hiding this comment.
Generally looks good. I didn't test it with the recent oasis-sdk version yet.
uniyalabhishek
force-pushed
the
uniyalabhishek/feature/format-known-addresses-131
branch
2 times, most recently
from
e6113ad to
0d546f8
Compare
fix(account show): propagate derived eth address refactor: unify address formatting context generation feat: add PrettyPrintWithTxDetails function and related tests refactor: replace PrettyAddressWith with PrettyAddress for address formatting chore: bump client-sdk/go to v0.16.1 to enable known address
uniyalabhishek
force-pushed
the
uniyalabhishek/feature/format-known-addresses-131
branch
from
fa2ea66 to
b656b4f
Compare
uniyalabhishek
deleted the
uniyalabhishek/feature/format-known-addresses-131
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes “known address” rendering consistent across CLI text output, and prefers Ethereum hex in parentheses when available (while still showing both addresses where required).
oasis wallet showandoasis account showdisplay both Ethereum + native addresses, elsewhere prefer Ethereum in parentheses when available.Dependency: This PR depends on oasis-sdk PR oasisprotocol/oasis-sdk#2335 being merged and a new
github.com/oasisprotocol/oasis-sdk/client-sdk/gorelease being published, after that we’ll bump the SDK version.