fix: header(s) overlapping scrolled to element (toc)#1504
fix: header(s) overlapping scrolled to element (toc)#1504WilcoSp wants to merge 2 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughThis pull request introduces scroll margin functionality across the application's routing system. Three page components are updated to define custom scroll margins via the Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
When using table of content the scroll behaviour caused that the scrolled to element to be underneath the header(s). I've now added scroll margin to the scroll behaviour so that scrolled to element isn't any more underneath the header(s).
by default the margin is 70 but it's possible with
definePageMetato set a different scroll margin, at least right now the package, code & docs pages have different scroll margins due to their additional headers.before:
-> 
after:
-> 
this will fix #1428