websocket: provide descriptive error on abnormal closure (fixes #4625)#4810
Open
M-YasirGhaffar wants to merge 1 commit intonodejs:mainfrom
Open
websocket: provide descriptive error on abnormal closure (fixes #4625)#4810M-YasirGhaffar wants to merge 1 commit intonodejs:mainfrom
M-YasirGhaffar wants to merge 1 commit intonodejs:mainfrom
Conversation
…s#4625) Signed-off-by: M-YasirGhaffar <yasirghaffar.nust@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes #4625
Rationale
When a WebSocket connection closes abnormally (code 1006) without completing the control frame exchange, the error event contained an empty
TypeErrormessage. This made debugging difficult as the error appeared cryptic with no description of what went wrong.Changes
lib/web/websocket/websocket.jsline 590 to use a fallback message whenreasonis emptytest/websocket/issue-4625.jsto verify the fix works for abnormal closuresFeatures
N/A
Bug Fixes
Breaking Changes and Deprecations
N/A
Status