fix: error stream instead of canceling#4804
Merged
KhafraDev merged 2 commits intonodejs:mainfrom Feb 4, 2026
Merged
Conversation
Co-authored-by: Matteo Collina <hello@matteocollina.com>
KhafraDev
commented
Feb 3, 2026
| controller.abort() | ||
|
|
||
| // Erroring a stream (see: https://fetch.spec.whatwg.org/#abort-fetch step 5) does not disturb it. | ||
| t.assert.strictEqual(response.bodyUsed, false) |
Member
Author
There was a problem hiding this comment.
In #4801 Claude, for some reason, thought bodyUsed was true here. All of the other tests are unchanged.
KhafraDev
commented
Feb 3, 2026
| return Promise.reject(new TypeError('Body is unusable: Body has already been read')) | ||
| } | ||
|
|
||
| if (state.aborted) { |
Member
Author
There was a problem hiding this comment.
I've wanted to remove this for years
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4804 +/- ##
==========================================
+ Coverage 93.24% 93.25% +0.01%
==========================================
Files 109 109
Lines 34100 34090 -10
==========================================
- Hits 31796 31791 -5
+ Misses 2304 2299 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
metcoder95
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4801
fixes #4799