Conversation
|
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
I don't know enough about the assumptions
|
|
||
| if ($newGroups !== null) { | ||
| $prefix = ''; | ||
| $mapping = $this->config->getSystemValue('user_saml.unique_groups_per_idp', ''); |
There was a problem hiding this comment.
are both settings new? then let's leave out the system one. do not need to make it more bloated then necessary.
There was a problem hiding this comment.
requested by customer to have the config in config/config.php instead of using the occ config:app:set
| if ($mapping !== '' && | ||
| array_key_exists($mapping, $attributes) && | ||
| is_array($attributes[$mapping]) && | ||
| sizeof($attributes[$mapping]) === 1) { |
There was a problem hiding this comment.
I'd fancy to have the operators on the left handside for better readability. On the right they are rugged and thus harder to spot. I am not sure whether we have written it down though in the coding style though.
| array_key_exists($mapping, $attributes) && | ||
| is_array($attributes[$mapping]) && | ||
| sizeof($attributes[$mapping]) === 1) { | ||
| $realUid = $attributes[$mapping][0]; |
There was a problem hiding this comment.
I am thinking of user id but that's not what it should be, or did I misunderstand it?
There was a problem hiding this comment.
this is to avoid a spoof of the domain from one of the idp
AndyScherzinger
force-pushed
the
feature/noid/isolate-groups-based-on-idp
branch
from
4f94cc1 to
9e19e04
Compare
|
@ArtificialOwl do we still need this? 🦗 |
2 participants
No description provided.