Skip to content

[release-1.11] NETOBSERV-2598: NETOBSERV-2517: Remove dependency on oc/kubectl#461

Merged
jotak merged 7 commits intonetobserv:release-1.11from
openshift-cherrypick-robot:cherry-pick-457-to-release-1.11
Feb 6, 2026
Merged

[release-1.11] NETOBSERV-2598: NETOBSERV-2517: Remove dependency on oc/kubectl#461
jotak merged 7 commits intonetobserv:release-1.11from
openshift-cherrypick-robot:cherry-pick-457-to-release-1.11

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #457

/assign jotak

jotak and others added 7 commits February 6, 2026 07:35
The --filename argument of the go binary, which isn't used at the
moment, is not sanitized for path traversal. This could be an unnoticed
vulnerability if we chose to leverage it later on.

This change uses go 1.24 "os.Root" API to prevent path traversal.
For some reason (??) it worked for get-flows but not for get-metrics ...
"eval" makes it work for metrics too
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 6, 2026

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: NETOBSERV-2598

Details

In response to this:

This is an automated cherry-pick of #457

/assign jotak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oliviercazade for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Feb 6, 2026

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a netobserv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.18%. Comparing base (06a5b1f) to head (e195a3b).
⚠️ Report is 1 commits behind head on release-1.11.

Files with missing lines Patch % Lines
internal/pkg/kubernetes/kubernetes.go 0.00% 8 Missing ⚠️
cmd/root.go 50.00% 4 Missing and 2 partials ⚠️
cmd/flow_capture.go 0.00% 4 Missing ⚠️
cmd/flow_db.go 80.00% 1 Missing ⚠️
cmd/packet_capture.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.11     #461      +/-   ##
================================================
+ Coverage         12.95%   13.18%   +0.22%     
================================================
  Files                19       20       +1     
  Lines              2439     2443       +4     
================================================
+ Hits                316      322       +6     
+ Misses             2099     2095       -4     
- Partials             24       26       +2     
Flag Coverage Δ
unittests 13.18% <33.33%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cmd/flow_db.go 52.38% <80.00%> (+0.41%) ⬆️
cmd/packet_capture.go 0.00% <0.00%> (ø)
cmd/flow_capture.go 7.59% <0.00%> (+0.61%) ⬆️
cmd/root.go 27.65% <50.00%> (+4.13%) ⬆️
internal/pkg/kubernetes/kubernetes.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jotak jotak merged commit cdccb82 into netobserv:release-1.11 Feb 6, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants