Updated tooling, converted to dotnet core/netstandard#6
Open
kdaveid wants to merge 2 commits intomoserware:masterfrom
Open
Updated tooling, converted to dotnet core/netstandard#6kdaveid wants to merge 2 commits intomoserware:masterfrom
kdaveid wants to merge 2 commits intomoserware:masterfrom
Conversation
|
kdaveid, the base project has some bugs which, if not corrected, can result in unrecoverable shares being produced. I have a pull request which corrects these bugs but the original author has not applied it. Unfortunately the changes were fairly involved. In any event in any serious use case you need to consider this prospect. If you have any questions I'll try to answer them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
Thanks for this awesome library
We're evaluating to use your library for a project and in this step we:
All unit tests are green, everything works as expected.