Open
Conversation
Owner
|
please rebase |
elmotec
force-pushed
the
get_series_with_realtime
branch
from
ef78d83 to
45a1ac2
Compare
Contributor
Author
|
Rebased. |
Removed usage of sys.stderr in mock exception which caused the stream to be closed. This in turn failed the next test. Simplified test_search to avoid the zip and the loop.
elmotec
force-pushed
the
get_series_with_realtime
branch
from
3fe6082 to
aa1db9b
Compare
Arguments realtime_start and realtime_end in get_series() now cause a pandas.DataFrame to be returned with pandas.MultiIndex for realtime data. Added simple test for the new feature and documentation. Added __init__.py in fredapi.tests so it's correctly interpreted as a package. Now we could revert to python setup.py test in .travis.yml. Fixed test_invalid_kwarg_in_get_series() as we sometimes get a TypeError and sometimes a ValueError. Seems that pandas passes through whatever exception it gets, might be a good reason for this so we follow the same policy. Simplified comparison of dataframe output in tests.
elmotec
force-pushed
the
get_series_with_realtime
branch
from
aa1db9b to
095b9f6
Compare
9999-12-31 cannot be converted to pandas.Timestamp because it's too big. Reason it's prefereable to use pandas.Timestamp than datetime.datetime is that the former can be used as an index whereas the second cannot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @mortada, this is a PR to address the issue I mentioned in #9. That's only the part that handle realtime_start and realtime_end as first class citizens in get_series().
I should have get_dataframe() (to query multiple series in one call at specific times) ready sometimes in October.