Add four Visualizer colormap function and png files#4737
Add four Visualizer colormap function and png files#4737smathimech wants to merge 5 commits intomodelica:masterfrom
Conversation
|
This is my first contribution to this modelica repository. I'm part of Modelon, India. I hope that, signed the CLA correctly. |
|
Mathi, thanks for adding these colormaps. You used two email addresses while committing, can you add the second address also to your github profile? The existing colormaps are all in this overview/comparison, maybe the new maps could be added there as well? |
tobolar
left a comment
There was a problem hiding this comment.
Thanks for this contribution. Please consider my comments below (resctricted to Modelica.Mechanics.MultiBody.Visualizers.Colors.ColorMaps).
-
The definition of
PlasmaandViridisseems to be identical. -
TrafficlightColorcan even be renamed toTrafficLight. -
Function name shall start with a lower case letter (see Modelica.UsersGuide.Conventions.ModelicaCode.Naming):
CoolWarm->coolWarmTrafficlightColorsimilarlyPlasmasimilarlyViridissimilarly
When renamed, please update also figure
Modelica/Resources/Images/Mechanics/MultiBody/Visualizers/Colors/ColorMaps/ColorMaps.pngaccordingly. -
Class description string is missing in
TrafficlightColorPlasmaViridis
-
For
TrafficlightColor, maybe the defaultn_colors=3makes more sense.
Thanks for the comments.
|
fe1c297 to
f1e4528
Compare
36d6992 to
12c70d2
Compare
12c70d2 to
b83aefb
Compare
There was a problem hiding this comment.
Any chance to regenerate all 11 color maps to have consistent font and color gradients?
Please change also the documentation. "The default value is "n_colors=64" (it is usually best if n_colors is a multiple of 4)." does not more fit. |


This MR address this issue #4689
Details: