Add doc how to build external C libraries with CMake#4734
Open
beutlich wants to merge 1 commit intomodelica:masterfrom
Open
Add doc how to build external C libraries with CMake#4734beutlich wants to merge 1 commit intomodelica:masterfrom
beutlich wants to merge 1 commit intomodelica:masterfrom
Conversation
beutlich
added
documentation
beutlich
force-pushed
the
update-cmake-doc
branch
from
258d9b5 to
03a42b6
Compare
Contributor
|
Nice explanation, but I do not want to build my own External C libraries, I just want to simulate model from the master branch. |
HansOlsson
reviewed
Feb 19, 2026
Comment on lines
+33
to
+34
| * `MODELICA_COPY_TABLE_DATA:BOOL=ON` | ||
| This flag avoids an undesired memory optimization of shallow-copying the passed table arrays. |
Contributor
There was a problem hiding this comment.
This description is bit too cryptic for me, I had to read it more than once to understand which setting avoided the problems - and then think more to understand which problems.
I would suggest something like the following.
Suggested change
| * `MODELICA_COPY_TABLE_DATA:BOOL=ON` | |
| This flag avoids an undesired memory optimization of shallow-copying the passed table arrays. | |
| * `MODELICA_COPY_TABLE_DATA:BOOL=ON` | |
| Copy table data in constructor. Disabling this optimizes memory use, but requires that the caller keeps the data. |
The second sentence could be skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4696.