Skip to content

ci: add strict-no-cover to detect unnecessary coverage pragmas #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxisbey wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: add strict-no-cover to detect unnecessary coverage pragmas #1897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/shared.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@ jobs:
uv run --frozen --no-sync coverage combine
uv run --frozen --no-sync coverage report

- name: Check for unnecessary no cover pragmas
if: runner.os != 'Windows'
Copy link
Contributor Author

@maxisbey maxisbey Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kludex without this all the windows pipelines fail to even run, seems like a strict-no-cover bug? Example failure from previous CI run: https://github.com/modelcontextprotocol/python-sdk/actions/runs/21070443439/job/60598385217

run: uv run --frozen --no-sync strict-no-cover

readme-snippets:
runs-on: ubuntu-latest
steps:
Expand Down
3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ dev = [
"dirty-equals>=0.9.0",
"coverage[toml]>=7.13.1",
"pillow>=12.0",
"strict-no-cover",
]
docs = [
"mkdocs>=1.6.1",
Expand Down Expand Up @@ -154,6 +155,7 @@ members = ["examples/clients/*", "examples/servers/*", "examples/snippets"]

[tool.uv.sources]
mcp = { workspace = true }
strict-no-cover = { git = "https://github.com/pydantic/strict-no-cover" }

[tool.pytest.ini_options]
log_cli = true
Expand Down Expand Up @@ -207,6 +209,7 @@ ignore_errors = true
precision = 2
exclude_lines = [
"pragma: no cover",
"pragma: lax no cover",
"if TYPE_CHECKING:",
"@overload",
"raise NotImplementedError",
Expand Down
11 changes: 11 additions & 0 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.