chore: use add all to make code simpler#96
Open
He-Pin wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
chore: use add all to make code simpler#96He-Pin wants to merge 1 commit intomodelcontextprotocol:mainfrom
He-Pin wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Signed-off-by: He-Pin <hepin1989@gmail.com>
tzolov
requested changes
Apr 6, 2025
| import java.util.HashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.*; |
Contributor
There was a problem hiding this comment.
Wildcard imports are discouraged as they can lead to namespace pollution and make it harder to track dependencies.
| for (McpServerFeatures.AsyncToolSpecification tool : toolSpecifications) { | ||
| this.tools.add(tool); | ||
| } | ||
| Collections.addAll(this.tools, toolSpecifications); |
Contributor
There was a problem hiding this comment.
Perhaps this.tools.addAll(List.of(toolSpecifications)) would do the job without needing additional/external libraries?
| for (ResourceTemplate resourceTemplate : resourceTemplates) { | ||
| this.resourceTemplates.add(resourceTemplate); | ||
| } | ||
| Collections.addAll(this.resourceTemplates, resourceTemplates); |
| for (McpServerFeatures.SyncToolSpecification tool : toolSpecifications) { | ||
| this.tools.add(tool); | ||
| } | ||
| Collections.addAll(this.tools, toolSpecifications); |
| for (ResourceTemplate resourceTemplate : resourceTemplates) { | ||
| this.resourceTemplates.add(resourceTemplate); | ||
| } | ||
| Collections.addAll(this.resourceTemplates, resourceTemplates); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Use add all to make code simpler
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context