HttpServletSseServerTransportProvider - replace path matching from getPathInfo to getRequestURI.#69
Closed
OrGivati wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
HttpServletSseServerTransportProvider - replace path matching from getPathInfo to getRequestURI.#69OrGivati wants to merge 1 commit intomodelcontextprotocol:mainfrom
getPathInfo to getRequestURI.#69OrGivati wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
`getRequestURI()` → full request path (without query). `getPathInfo()` → extra path after the servlet's mapping, or null if none. So if I am configuring my Servlet to be mapped on `/somePath` and initiating the Servlet: ``` new HttpServletSseServerTransport(new ObjectMapper(), "/somePath/message", "/somePath/sse") ``` it will work and won't fail. `getPathInfo` will return "/message" and "/sse". while `getRequestURI` will return "/somePath/message" and "/somePath/sse" and will not fail on the validation.
tzolov
added a commit
that referenced
this pull request
Mar 27, 2025
- Add support for customizable SSE endpoints in HttpClientSseClientTransport - Replace pathInfo with requestURI in HttpServletSseServerTransportProvider for more reliable endpoint matching - Implement builder pattern to support the customization options Related to #40 Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com> Co-authored-by: Christian Tzolov <christian.tzolov@broadcom.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix path matching in HttpServletSseServerTransport
Problem
When configuring a Servlet mapped to
/somePath/*and initializingHttpServletSseServerTransportwith:The handshake phase fails because the current implementation uses
getPathInfo()which only returns the path after the servlet mapping (e.g., "/message" and "/sse"), not the full configured path.Using
getRequestURI()instead will correctly return "/somePath/message" and "/somePath/sse", allowing proper validation.Motivation and Context
I need to map my Servlet to a custom URI pattern like
/somePath/*using web.xml configuration. Currently, path validation indoPost()fails becausegetPathInfo()only returns the part of the path after the servlet mapping, rather than the complete path specified during initialization.How Has This Been Tested?
Existing tests continue to pass. Note that the current MCP client doesn't support custom SSE endpoints, so additional testing may be needed.
Breaking Changes
None identified.
Types of changes
Checklist
Additional context