Merged
Conversation
Contributor
Kehrlann
commented
Nov 20, 2025
Kehrlann
commented
- We do not support full version negotiation, but this commit allows the client to the send the correct version to match that of the server.
- There is one limitation: the GET /mcp request happens too early, before we have deserialized the initialization response, so we do not know the negotiated version yet. This request will have the client latest version as Mcp-Protocol-Version value.
chemicL
approved these changes
Nov 21, 2025
Member
chemicL
left a comment
chemicL
left a comment
There was a problem hiding this comment.
Nice improvement! Left a couple non-critical suggestions.
| .header(HttpHeaders.MCP_SESSION_ID, sessionId) | ||
| .header(HttpHeaders.PROTOCOL_VERSION, this.latestSupportedProtocolVersion) | ||
| .header(HttpHeaders.PROTOCOL_VERSION, | ||
| ctx.getOrDefault(McpAsyncClient.NEGOTIATED_PROTOCOL_VERSION, |
Member
There was a problem hiding this comment.
since this snippet appears 3 times in this file, perhaps a helper protocolVersion(Context) could be useful?
| assertThat(calls).filteredOn(c -> !c.body().contains("\"method\":\"initialize\"")) | ||
| // GET /mcp ; POST notification/initialized ; POST tools/call | ||
| .hasSize(3) | ||
| // Initialize does not know the server's protocol |
- We do not support full version negotiation, but this commit allows the client to the send the correct version to match that of the server. - There is one limitation: the GET /mcp request happens too early, before we have deserialized the initialization response, so we do not know the negotiated version yet. This request will have the client latest version as Mcp-Protocol-Version value. Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Kehrlann
force-pushed
the
dgarnier/version-negotiation
branch
from
7721608 to
584f949
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.